From 31ec6ab1115515786e9c6cbd85ddb2cc6998ec4f Mon Sep 17 00:00:00 2001 From: Ewan Mellor Date: Fri, 23 Mar 2007 16:54:34 +0000 Subject: [PATCH] Release the domains_lock properly when get_dev_property_by_uuid fails. Signed-off-by: Ewan Mellor --- tools/python/xen/xend/XendDomain.py | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/tools/python/xen/xend/XendDomain.py b/tools/python/xen/xend/XendDomain.py index 5f99db8941..d0c0dd1daf 100644 --- a/tools/python/xen/xend/XendDomain.py +++ b/tools/python/xen/xend/XendDomain.py @@ -653,14 +653,16 @@ class XendDomain: def get_dev_property_by_uuid(self, klass, dev_uuid, field): value = None self.domains_lock.acquire() - try: - dom = self.get_vm_with_dev_uuid(klass, dev_uuid) - if dom: - value = dom.get_dev_property(klass, dev_uuid, field) - except ValueError, e: - pass - self.domains_lock.release() + try: + try: + dom = self.get_vm_with_dev_uuid(klass, dev_uuid) + if dom: + value = dom.get_dev_property(klass, dev_uuid, field) + except ValueError, e: + pass + finally: + self.domains_lock.release() return value -- 2.30.2